chore: rename and add a comment to aws header method

spacelift-io · Nov 28, 2024 · 648406f · 648406f
1 parent 5a364cb
commit 648406f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/internal/cmd/provider/create_version.go b/internal/cmd/provider/create_version.go
@@ -75,12 +75,12 @@ func createVersion() cli.ActionFunc {
 		}
 
 		fmt.Println("Uploading the checksums file")
-		if err := checksumsFile.Upload(cliCtx.Context, dir, createMutation.CreateTerraformProviderVersion.SHA256SumsUploadURL, checksumsFile.MetadataHeaders()); err != nil {
+		if err := checksumsFile.Upload(cliCtx.Context, dir, createMutation.CreateTerraformProviderVersion.SHA256SumsUploadURL, checksumsFile.AWSMetadataHeaders()); err != nil {
 			return errors.Wrap(err, "could not upload checksums file")
 		}
 
 		fmt.Println("Uploading the signatures file")
-		if err := signatureFile.Upload(cliCtx.Context, dir, createMutation.CreateTerraformProviderVersion.SHA256SumsSigUploadURL, signatureFile.MetadataHeaders()); err != nil {
+		if err := signatureFile.Upload(cliCtx.Context, dir, createMutation.CreateTerraformProviderVersion.SHA256SumsSigUploadURL, signatureFile.AWSMetadataHeaders()); err != nil {
 			return errors.Wrap(err, "could not upload signature file")
 		}
 
@@ -156,7 +156,7 @@ func registerPlatform(ctx context.Context, dir string, versionID string, artifac
 		return err
 	}
 
-	if err := artifact.Upload(ctx, dir, mutation.RegisterTerraformProviderVersionPlatform, artifact.MetadataHeaders()); err != nil {
+	if err := artifact.Upload(ctx, dir, mutation.RegisterTerraformProviderVersionPlatform, artifact.AWSMetadataHeaders()); err != nil {
 		return errors.Wrapf(err, "could not upload artifact: %s", artifact.Name)
 	}
 

diff --git a/internal/cmd/provider/internal/goreleaser.go b/internal/cmd/provider/internal/goreleaser.go
@@ -179,7 +179,9 @@ func (a *GoReleaserArtifact) Upload(ctx context.Context, dir string, url string,
 	return nil
 }
 
-func (a *GoReleaserArtifact) MetadataHeaders() http.Header {
+// AWSMetadataHeaders returns the headers required for uploading with an AWS presigned URL.
+// Deprecated: Use UploadHeaders from the gql TerraformProviderVersionRegisterPlatformV2 response instead.
+func (a *GoReleaserArtifact) AWSMetadataHeaders() http.Header {
 	headers := http.Header{}
 	if a.OS != nil {
 		headers.Set("x-amz-meta-binary-os", *a.OS)