Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add more repo tests #41

Merged
merged 1 commit into from
Jun 18, 2024
Merged

chore: add more repo tests #41

merged 1 commit into from
Jun 18, 2024

Conversation

eliecharra
Copy link
Member

No description provided.

@eliecharra eliecharra requested a review from peterdeme June 17, 2024 17:12
@eliecharra eliecharra requested a review from a team as a code owner June 17, 2024 17:12
@eliecharra eliecharra marked this pull request as draft June 18, 2024 08:09
@eliecharra eliecharra force-pushed the chore/add_more_repo_tests branch from 97cdbe7 to 291676c Compare June 18, 2024 08:21
@eliecharra eliecharra marked this pull request as ready for review June 18, 2024 08:22
Base automatically changed from fix/make_spec_name_optional to main June 18, 2024 08:55
@eliecharra eliecharra force-pushed the chore/add_more_repo_tests branch from 291676c to 9c47005 Compare June 18, 2024 08:57
Comment on lines +81 to +82
spaceMutation := mutation.(*spaceCreateMutation)
spaceMutation.SpaceCreate.ID = "space-id"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have mixed feelings about the usefulness of these tests but 🤷 we might as well do integration tests at this point

@eliecharra eliecharra merged commit 6537d97 into main Jun 18, 2024
5 checks passed
@eliecharra eliecharra deleted the chore/add_more_repo_tests branch June 18, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants