Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multivcs trunk #481

Merged
merged 3 commits into from
Feb 5, 2024
Merged

Multivcs trunk #481

merged 3 commits into from
Feb 5, 2024

Conversation

peterdeme
Copy link
Contributor

@peterdeme peterdeme commented Nov 20, 2023 •
edited
Loading

Description of the change

This is a PR for the multi VCS work which includes all VCS integrations.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (non-breaking change that adds documentation)

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development
  • Examples for new resources and data sources have been added
  • Default values have been documented in the description (e.g., "Dummy: (Boolean) Blah blah. Defaults to false.)
  • If the action fails that checks the documentation: Run go generate to make sure the docs are up to date

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Pull Request is no longer marked as "draft"
  • Reviewers have been assigned
  • Changes have been reviewed by at least one other engineer

@peterdeme peterdeme force-pushed the multivcs-trunk branch 2 times, most recently from 059e66c to b9d7d62 Compare November 28, 2023 14:20
truszkowski
truszkowski previously approved these changes Jan 22, 2024
View reviewed changes
spacelift/data_stack.go Show resolved Hide resolved
spacelift/data_stack.go Outdated Show resolved Hide resolved
spacelift/data_stack.go Outdated Show resolved Hide resolved
spacelift/data_module.go Outdated Show resolved Hide resolved
@peterdeme
Copy link
Contributor Author

I'm squashing the commits.

@peterdeme peterdeme force-pushed the multivcs-trunk branch 2 times, most recently from 9190746 to 00daf9a Compare January 22, 2024 12:18
@peterdeme peterdeme marked this pull request as ready for review February 5, 2024 13:30
@peterdeme peterdeme merged commit fa45049 into main Feb 5, 2024
7 checks passed
@peterdeme peterdeme deleted the multivcs-trunk branch February 5, 2024 13:45
truszkowski added a commit that referenced this pull request Mar 4, 2024
@peterdeme @truszkowski
Multi VCS (#481)
a52fd96 
* Multi VCS (#477)

* GitHub Integration: add missing webhook url

* GitHub Integration: add missing webhook url (update doc)

---------

Co-authored-by: Piotr Truszkowski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@truszkowski truszkowski truszkowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterdeme @truszkowski