Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional_project_globs to stack #483

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Conversation

tomasmik
Copy link
Contributor

@tomasmik tomasmik commented Nov 23, 2023

Description of the change

Description here

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (non-breaking change that adds documentation)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development
  • Examples for new resources and data sources have been added
  • Default values have been documented in the description (e.g., "Dummy: (Boolean) Blah blah. Defaults to false.)
  • If the action fails that checks the documentation: Run go generate to make sure the docs are up to date

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Pull Request is no longer marked as "draft"
  • Reviewers have been assigned
  • Changes have been reviewed by at least one other engineer

@tomasmik tomasmik self-assigned this Nov 23, 2023
@Clickup-user
Copy link

@tomasmik tomasmik force-pushed the cu-8692zz92u-add-project-globs branch 4 times, most recently from a8171d4 to 8113889 Compare November 23, 2023 13:38
@tomasmik tomasmik marked this pull request as ready for review November 23, 2023 13:56
Copy link
Contributor

@mbialon mbialon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tomasmik tomasmik force-pushed the cu-8692zz92u-add-project-globs branch from 8113889 to 33e19ee Compare November 28, 2023 09:44
@tomasmik tomasmik merged commit 6f66a70 into main Nov 28, 2023
7 checks passed
@tomasmik tomasmik deleted the cu-8692zz92u-add-project-globs branch November 28, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants