feat(security-email): add support for security email #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwasilew2
force-pushed
the
CU-8693fq8dx_add-support-for-security_email-to-terraform-provider_Michal-Wasilewski
branch
from
741fd88 to
941f6d2
Compare
|
similar to: #495 |
spacelift/resource_security_email.go
Outdated
| } | ||
|
|
||
| func resourceSecurityEmailDelete(ctx context.Context, data *schema.ResourceData, i interface{}) diag.Diagnostics { | ||
| return diag.Errorf("deleting security email is not supported") |
There was a problem hiding this comment.
This doesn't seem a great UX. Wouldn't it mean that if you had added this resource, you'd need to remove it from the Terraform state in order to be able to delete the resource?
I wonder if we should do something like this:
- Update the API to allow the security email to be set to an empty string / null; or
- Turn this into a no-op (maybe with a warning).
There was a problem hiding this comment.
you'd need to remove it from the Terraform state in order to be able to delete the resource?
yes
I'll turn it into a warning and remove the resource from the state
adamconnelly
approved these changes
Jan 25, 2024
Signed-off-by: Michal Wasilewski <[email protected]>
mwasilew2
force-pushed
the
CU-8693fq8dx_add-support-for-security_email-to-terraform-provider_Michal-Wasilewski
branch
from
bf491c9 to
67aa628
Compare
mwasilew2
deleted the
CU-8693fq8dx_add-support-for-security_email-to-terraform-provider_Michal-Wasilewski
branch
truszkowski
pushed a commit
that referenced
this pull request
Mar 4, 2024
Signed-off-by: Michal Wasilewski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
related to: https://app.clickup.com/t/8693fq8dx
Adds to the terraform provider support for editing security email.
Note: the graphql api doesn't currently support deleting security email and terraform test sdk runs delete after each test
Type of change
Related issues
Checklists
Development
false.)go generateto make sure the docs are up to dateCode review