Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added resources for saved filter handling #521

Merged
merged 4 commits into from
Mar 5, 2024

Conversation

truszkowski
Copy link
Contributor

@truszkowski truszkowski commented Mar 4, 2024

Description of the change

Copied from: PR. GitHub Action secrets don't work with forks.

Added resource and data source for handling of spacelift saved filter, E.g. to be able to add predefined filters for different teams.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (non-breaking change that adds documentation)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development
  • Examples for new resources and data sources have been added
  • Default values have been documented in the description (e.g., "Dummy: (Boolean) Blah blah. Defaults to false.)
  • If the action fails that checks the documentation: Run go generate to make sure the docs are up to date

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Pull Request is no longer marked as "draft"
  • Reviewers have been assigned
  • Changes have been reviewed by at least one other engineer

spacelift/data_saved_filter.go Show resolved Hide resolved
spacelift/data_saved_filters.go Outdated Show resolved Hide resolved
spacelift/data_saved_filters.go Show resolved Hide resolved
spacelift/data_saved_filters.go Show resolved Hide resolved
@truszkowski truszkowski force-pushed the add_saved_filter_resource branch from 97a2999 to ad697d1 Compare March 4, 2024 08:33
@truszkowski truszkowski requested review from TheMacies, peterdeme and a team March 4, 2024 11:36
Copy link
Contributor

@adamconnelly adamconnelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good. Left some comments, but nothing major.

spacelift/data_saved_filter.go Show resolved Hide resolved
spacelift/data_saved_filters.go Outdated Show resolved Hide resolved
spacelift/data_saved_filters_test.go Show resolved Hide resolved
Copy link
Contributor

@adamconnelly adamconnelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@truszkowski truszkowski merged commit 702e125 into main Mar 5, 2024
7 checks passed
@truszkowski truszkowski deleted the add_saved_filter_resource branch March 5, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants