Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add kubernete_workflow_tool property to the kubernetes schema #592

Merged
merged 6 commits into from
Jan 13, 2025

Conversation

michalrom089
Copy link
Contributor

@michalrom089 michalrom089 commented Jan 9, 2025

Description of the change

Currently, users can only select custom workflow through the UI. A user has requested to be able to do it through the provider also.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (non-breaking change that adds documentation)

Related issues

Support custom workflow for kubernetes stack through terraform creation.

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development
  • Examples for new resources and data sources have been added
  • Default values have been documented in the description (e.g., "Dummy: (Boolean) Blah blah. Defaults to false.)
  • If the action fails that checks the documentation: Run go generate to make sure the docs are up to date

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Pull Request is no longer marked as "draft"
  • Reviewers have been assigned
  • Changes have been reviewed by at least one other engineer

@michalrom089 michalrom089 changed the title Add kubernete_workflow_tool property for kubernetes schema Add kubernete_workflow_tool property to the kubernetes schema Jan 9, 2025
@michalrom089 michalrom089 marked this pull request as ready for review January 10, 2025 15:29
@michalrom089 michalrom089 requested a review from michalg9 January 10, 2025 15:29
@michalrom089
Copy link
Contributor Author

michalrom089 commented Jan 10, 2025

Tests fail because we don't handle pages here

and the error is very vague due to some sync problems, I will try to tackle this too - it is thrown here, it continues on error and gets overridden:

	err = g.checkError(response, err)
	if err == nil {
		req.environmentID = gitlab.Int(environment.ID)
		return nil
	}

EDIT: here's a fix

Copy link
Contributor

@mwasilew2 mwasilew2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

As for the release, please hold on until the backend fix is deployed to production

@michalrom089 michalrom089 changed the title Add kubernete_workflow_tool property to the kubernetes schema feat: add kubernete_workflow_tool property to the kubernetes schema Jan 13, 2025
@michalrom089 michalrom089 changed the title feat: add kubernete_workflow_tool property to the kubernetes schema feat: add kubernete_workflow_tool property to the kubernetes schema Jan 13, 2025
@michalrom089 michalrom089 merged commit fbbbfbe into main Jan 13, 2025
7 checks passed
@michalrom089 michalrom089 deleted the cu-8694afyu7–kubernetes-custom-workflow branch January 13, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants