Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix secret field shenanigans caused by backend change #605

Merged
merged 1 commit into from
Feb 7, 2025
Merged

Fix secret field shenanigans caused by backend change #605

merged 1 commit into from
Feb 7, 2025

Conversation

peterdeme
Copy link
Contributor

@peterdeme peterdeme commented Feb 6, 2025 •
edited
Loading

Description of the change

The test started to fail since we stopped returning the secret value. Let's just ignore value changes from now on, and ForceNew.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (non-breaking change that adds documentation)

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development
  • Examples for new resources and data sources have been added
  • Default values have been documented in the description (e.g., "Dummy: (Boolean) Blah blah. Defaults to false.)
  • If the action fails that checks the documentation: Run go generate to make sure the docs are up to date

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Pull Request is no longer marked as "draft"
  • Reviewers have been assigned
  • Changes have been reviewed by at least one other engineer

@peterdeme peterdeme requested review from tomasmik and a team February 6, 2025 17:39
@peterdeme peterdeme marked this pull request as ready for review February 6, 2025 17:41
Apollorion
Apollorion previously approved these changes Feb 6, 2025
View reviewed changes
tomasmik
tomasmik previously approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@tomasmik tomasmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks <3

@peterdeme peterdeme force-pushed the fix-failing-test branch 2 times, most recently from 2a17c9a to 98467f3 Compare February 7, 2025 09:53
@peterdeme
Set secrets to empty string
281c6a6 
A bunch of tests started to fail since we stopped returning the secret
value. Let's just ignore value changes from now on, and `ForceNew`.

Signed-off-by: peterdeme <[email protected]>
@peterdeme peterdeme merged commit ace8fec into main Feb 7, 2025
7 checks passed
@peterdeme peterdeme deleted the fix-failing-test branch February 7, 2025 12:33
@peterdeme peterdeme changed the title Fix failing test due to backend change Fix secret field shenanigans caused by backend change Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Apollorion Apollorion Apollorion left review comments

@tomasmik tomasmik tomasmik left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peterdeme @Apollorion @tomasmik