Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This push request is about handling Traefik ipallowlist to synapse-ad… #4063

Merged
merged 4 commits into from
Feb 14, 2025

Conversation

akdk7
Copy link
Contributor

@akdk7 akdk7 commented Feb 12, 2025

This push request is about handling Traefik ipallowlist to synapse-admin.

It's my first push request. If I forgot something please let me know. :-)

…min application.

It's my first push request. If I forgot something please let me know. :-)
Copy link
Owner

@spantaleev spantaleev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your first contribution! 🙇

I've submitted some feedback for how this can be improved!

roles/custom/matrix-synapse-admin/defaults/main.yml Outdated Show resolved Hide resolved
roles/custom/matrix-synapse-admin/templates/labels.j2 Outdated Show resolved Hide resolved
@akdk7
Copy link
Contributor Author

akdk7 commented Feb 13, 2025

@spantaleev
Thank you very much for your detailed input. I have commit your recommended changes. :)

@akdk7 akdk7 requested a review from spantaleev February 13, 2025 16:35
@spantaleev spantaleev merged commit 15f7f41 into spantaleev:master Feb 14, 2025
2 checks passed
@spantaleev
Copy link
Owner

Thank you! 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants