Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional non-adjusting temperatures activated by removing comment… #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jimprince
Copy link

@jimprince jimprince commented Feb 22, 2019

I thought it was a useful feature as the first thing I did was walk around with the camera and look at stuff. It made it a bit easier to get a feel for the absolute temperature of the objects around me (walking through my house during winter) as opposed to just relative temperature between them. I've never submitted a PR before so if is customary to include more or you need anything else, just let me know.

@nseidle
Copy link
Member

nseidle commented Mar 4, 2019

Thanks for the PR! Looks pretty good but the only change I see in this pr is the addition of a few comments:

image

Is that your intent?

@jimprince
Copy link
Author

Hey! Thanks for getting back to me. Yeah, just by uncommenting those two lines you get a static temperature range on the output image instead of a dynamically adjusting temperature range (where the colors change based on the min and max temperature in the frame).

I'll try and take a couple pictures with it both enabled and disabled so you can see what the difference looks like and if you want to include it. It may take me a couple days as I put my sensor away as I'm moving at the moment. Will post back soon.

Cheers!

@nseidle
Copy link
Member

nseidle commented Mar 6, 2019

Got it. Thanks for the explanation. Images would be helpful for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants