feature (tekla): extract user-defined attributes #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #566 +/- ##
=====================================
Coverage 8.54% 8.54%
=====================================
Files 229 229
Lines 4365 4365
Branches 552 552
=====================================
Hits 373 373
Misses 3977 3977
Partials 15 15 ☔ View full report in Codecov by Sentry. |
clairekuang
requested changes
Feb 6, 2025
|
|
||
| if (propertyName != null) | ||
| { | ||
| var reportProperty = new Dictionary<string, object?> { ["name"] = propertyName, ["value"] = propertyValue }; |
There was a problem hiding this comment.
these should be entries in the userProperties dictionary, not single entry dictionaries
There was a problem hiding this comment.
right, it looks cleaner now. pushed.
clairekuang
requested changes
Feb 6, 2025
Converters/Tekla/Speckle.Converters.TeklaShared/ToSpeckle/Helpers/PropertiesExtractor.cs
Outdated
Show resolved
Hide resolved
clairekuang
approved these changes
Feb 10, 2025
clairekuang
deleted the
dogukan/cnx-1185-extract-user-defined-attributes-in-tekla
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
user-defined attributes was requested a couple of times. added to property extractor.