Skip to content

Revert "LaTeX: extend to all projects the #3742 fix for PDF builds at RTD" #5239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2018

Conversation

@jfbu jfbu added this to the 1.8.0 milestone Jul 31, 2018
@codecov
Copy link

codecov bot commented Jul 31, 2018

Codecov Report

Merging #5239 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5239      +/-   ##
==========================================
+ Coverage   82.25%   82.26%   +0.01%     
==========================================
  Files         301      295       -6     
  Lines       39558    39221     -337     
  Branches     6078     6024      -54     
==========================================
- Hits        32537    32264     -273     
+ Misses       5687     5631      -56     
+ Partials     1334     1326       -8
Impacted Files Coverage Δ
sphinx/writers/latex.py 84.02% <ø> (ø) ⬆️
sphinx/quickstart.py
sphinx/errors.py
sphinx/__init__.py
sphinx/search/__init__.py
sphinx/make_mode.py
sphinx/apidoc.py
sphinx/builders/html.py 82.81% <0%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8de8f08...f0067f4. Read the comment docs.

@jfbu
Copy link
Contributor Author

jfbu commented Jul 31, 2018

Thanks @tk0miya for quick review and sorry for oversight at #5181 that I did not think of projects without general index. Anyway, RTD policy of only two pdflatex runs and a hard-coded makeindex call causes problem also with xindy usage, so I hope they will use our Makefile and Latexmk, even though it basically means 3 pdflatex runs, but that's more or less unavoidable as latex is a multi-pass system.

Now merging.

@jfbu jfbu merged commit 5edcb28 into sphinx-doc:master Jul 31, 2018
@jfbu jfbu deleted the latex_revert_5181_RTDbug_workaround branch July 31, 2018 17:13
jfbu added a commit that referenced this pull request Jul 31, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants