Use canonical URLs when ogp_site_url is not configured #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ItayZiv
force-pushed
the
fix-html-baseurl
branch
from
2a88207 to
80279c4
Compare
ItayZiv
changed the title
Daltz333
reviewed
Feb 25, 2022
|
Not sure if we should test if this runs https://github.com/wpilibsuite/sphinxext-opengraph/blob/3d436363bf8927fe3885d991ad2d2067cc7f3891/sphinxext/opengraph/__init__.py#L79 |
|
Closed in 98c36cb |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix support for automatically getting the
ogp_site_urlin RTD environments and in all environments by using the canonical URL that RTD configures in Sphinx (html_baseurl)Closes #55.