fix(core): fix InMemoryTaskRepository.listByThisInstance #6339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
which currently passes for RedisTaskRepositoryTest and SqlTaskRepositoryTest (because of fixes in spinnaker#5680), but fails in InMemoryTaskRepositoryTest. Fix for that to follow.
to return only tasks owned by this clouddriver instance
…itory.runningTaskIds
so it's more obvious when clouddriver is shutting down.
jasonmcintosh
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to return only tasks owned by this clouddriver instance
and some other small cleanups, including adding a test which #5680 already fixed.