test(ldap/roles): minor improvement

spinnaker · Jul 29, 2024 · 750f2b3 · 750f2b3
1 parent 6834e33
commit 750f2b3
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/...ap/src/test/groovy/com/netflix/spinnaker/fiat/roles/ldap/LdapUserRolesProviderTest.groovy b/...ap/src/test/groovy/com/netflix/spinnaker/fiat/roles/ldap/LdapUserRolesProviderTest.groovy
@@ -295,14 +295,15 @@ class LdapUserRolesProviderTest extends Specification {
     def configProps = baseConfigProps()
 
     def provider = Spy(LdapUserRolesProvider) {
-      getPartialUserDn(_ as String) >> null
-      getUserDNs(_ as Collection<String>) >> [ 'uid=dn1,ou=users,dc=springframework,dc=org' : 'user1',
+      1 * getPartialUserDn(_ as String) >> null
+      1 * getUserDNs(_ as Collection<String>) >> [ 'uid=dn1,ou=users,dc=springframework,dc=org' : 'user1',
                                                'uid=dn2,ou=users,dc=springframework,dc=org' : 'user1']
+      0 * getUserFullDn(_ as String)
     }
     provider.ldapTemplate = Mock(SpringSecurityLdapTemplate) {
-      _ * searchForSingleEntry(*_) >> { throw new IncorrectResultSizeDataAccessException(1) }
-      _ * searchForSingleAttributeValues(_, _, ['uid=dn1,ou=users,dc=springframework,dc=org','user1'], _) >> ['group1']
-      _ * searchForSingleAttributeValues(_, _, ['uid=dn2,ou=users,dc=springframework,dc=org','user1'], _) >> ['group2']
+      1 * searchForSingleAttributeValues(_, _, ['uid=dn1,ou=users,dc=springframework,dc=org','user1'], _) >> ['group1']
+      1 * searchForSingleAttributeValues(_, _, ['uid=dn2,ou=users,dc=springframework,dc=org','user1'], _) >> ['group2']
+      0 * searchForSingleEntry(*_)
     }
     provider.setConfigProps(configProps)