Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mask #1900

Merged
merged 32 commits into from
Feb 19, 2025
Merged
Changes from 1 commit
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
6b3b101
feat: mask
danking Jan 6, 2025
c25b668
remove unnecssary clone
danking Jan 13, 2025
26c4613
clippy again
danking Jan 13, 2025
469f401
revert datetime-parts changes
danking Jan 14, 2025
757d1b8
extension arrays are neither castable nor maskable
danking Jan 15, 2025
e7de227
Merge remote-tracking branch 'origin/develop' into dk/mask
danking Jan 16, 2025
4bf1e0c
revert ALP mask for now
danking Jan 16, 2025
2110ee2
use slice::fill instead of a loop
danking Jan 16, 2025
373ae02
fix: non-nullable dict array needs a leading empty element
danking Jan 16, 2025
e6bf8f0
better error message when casting BoolArray to non-bool dtype.
danking Jan 16, 2025
bf2bbd2
test that changing name order is not allowed
danking Jan 17, 2025
5b98893
remove DictArray mask for now
danking Jan 17, 2025
6d5af14
fix varbin and varbinview casts
danking Jan 21, 2025
732171e
Merge remote-tracking branch 'origin/develop' into dk/mask
danking Jan 21, 2025
af00e5c
clippy
danking Jan 21, 2025
5c43574
clippy
danking Jan 21, 2025
fe393c0
clippy
danking Jan 21, 2025
169fe33
Merge remote-tracking branch 'origin/develop' into dk/mask
danking Feb 3, 2025
64b714d
remove cruft
danking Feb 3, 2025
cb0fabd
revert unused changes
danking Feb 3, 2025
77740e8
cleanups
danking Feb 3, 2025
4d909eb
validity array not supporting min is an error
danking Feb 3, 2025
ac41d69
lift validity failure before boolean buffer creation
danking Feb 3, 2025
efb9881
final fixups
danking Feb 3, 2025
94c731c
Merge remote-tracking branch 'origin/develop' into dk/mask
danking Feb 4, 2025
49d4a0d
Merge remote-tracking branch 'origin/develop' into dk/mask
danking Feb 6, 2025
256f013
use new idioms for true count
danking Feb 6, 2025
041e913
Merge remote-tracking branch 'origin/develop' into dk/mask
danking Feb 18, 2025
3ec13c0
fixes
danking Feb 18, 2025
554f492
test mask on dict array
danking Feb 18, 2025
3445488
revert change
danking Feb 18, 2025
5e2f415
StructArray children includes validity: must use fields()
danking Feb 18, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
StructArray children includes validity: must use fields()
danking committed Feb 18, 2025
commit 5e2f41533c86046bdea557ebc3dfe6b224683abe
2 changes: 1 addition & 1 deletion vortex-array/src/array/struct_/compute/mod.rs
Original file line number Diff line number Diff line change
@@ -149,7 +149,7 @@ impl MaskFn<StructArray> for StructEncoding {

StructArray::try_new(
array.names().clone(),
array.children(),
array.fields().collect(),
array.len(),
validity,
)