Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow duplicate field names in StructDType #2182

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Disallow duplicate field names in StructDType #2182

wants to merge 5 commits into from

Conversation

AdamGS
Copy link
Contributor

@AdamGS AdamGS commented Feb 1, 2025

closes #2164.

AdamGS
AdamGS commented Feb 1, 2025
View reviewed changes
vortex-dtype/src/struct_.rs
}

#[allow(clippy::disallowed_types)]
let mut unique_names = std::collections::HashSet::new();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moving the aliases doesn't seem worthwhile here

@AdamGS
Copy link
Contributor Author

AdamGS commented Feb 1, 2025

interesting test failure

@robert3005
Copy link
Member

I commented on the original issue that we should enforce projections are unique and then users can choose to make a copy under different name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disallow duplicate field names in StrucDType
2 participants
@AdamGS @robert3005