feat: Add tracing #2276
Merged
feat: Add tracing #2276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamGS
reviewed
Feb 8, 2025
|
Would also be useful to print out a "file map", maybe in the TUI, that looks like this: |
|
So far - seems like perfetto is the best semi-local option |
AdamGS
reviewed
Feb 10, 2025
AdamGS
approved these changes
Feb 10, 2025
AdamGS
added a commit
that referenced
this pull request
Feb 11, 2025
I added `*.svg` in #2276 because some flamegraphs are svgs, but we actually want some svg files for docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Layout names are human-readable paths throught the layout tree, very useful for logging!
Right now its a compile time feature, and it dumps a profile file that can be used with perfetto.
I tried to get a local jaeger setup to work, but something was missing with the otel config and I wasn't impressed enough with the UI to keep chasing it.