Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow updates and standardized pre-commit changes and configurations added #30

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/workflows/call-publish.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
name: Call Publish Workflow

on:
push:
branches:
- main # Runs only on push (merge) to main

jobs:
call-publish:
uses: splunk-soar-connectors/.github/.github/workflows/publish.yml@main
13 changes: 13 additions & 0 deletions .github/workflows/call-push.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
name: Call Push Workflow

on:
pull_request:
branches-ignore:
- main # Runs only on non-main branches
types:
- opened # When a new PR is opened
- synchronize # When a new commit is pushed to the PR branch

jobs:
call-push:
uses: splunk-soar-connectors/.github/.github/workflows/push.yml@main
20 changes: 0 additions & 20 deletions .github/workflows/generate-doc.yml

This file was deleted.

11 changes: 0 additions & 11 deletions .github/workflows/linting.yml

This file was deleted.

22 changes: 0 additions & 22 deletions .github/workflows/review-release.yml

This file was deleted.

13 changes: 0 additions & 13 deletions .github/workflows/start-release.yml

This file was deleted.

60 changes: 53 additions & 7 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
@@ -1,11 +1,57 @@
# See https://pre-commit.com for more information
# See https://pre-commit.com/hooks.html for more hooks

# This is a template for connector pre-commit hooks
repos:
- repo: https://github.com/phantomcyber/dev-cicd-tools
rev: v1.18
- repo: https://github.com/compilerla/conventional-pre-commit
rev: v4.0.0
hooks:
- id: org-hook
- id: package-app-dependencies
- repo: https://github.com/Yelp/detect-secrets
- id: conventional-pre-commit
stages: [commit-msg]
args: [--verbose]
- repo: https://github.com/pre-commit/pre-commit-hooks
rev: v3.2.0
hooks:
- id: check-merge-conflict
- id: end-of-file-fixer
exclude_types: [ markdown ]
- id: trailing-whitespace
exclude_types: [ markdown ]
- id: requirements-txt-fixer
- id: check-json
- id: check-yaml
- repo: https://github.com/astral-sh/ruff-pre-commit
rev: v0.9.6
hooks:
- id: ruff
args: [ "--fix", "--unsafe-fixes"] # Allow unsafe fixes (ruff pretty strict about what it can fix)
- id: ruff-format
- repo: https://github.com/djlint/djLint
rev: v1.36.4
hooks:
- id: djlint-reformat-django
- id: djlint-django
- repo: https://github.com/hukkin/mdformat
rev: 0.7.22
hooks:
- id: mdformat
exclude: "release_notes/.*"
- repo: https://github.com/returntocorp/semgrep
rev: v1.107.0
hooks:
- id: semgrep
- repo: https://github.com/Yelp/detect-secrets
rev: v1.5.0
hooks:
- id: detect-secrets
args: ['--no-verify', '--exclude-files', '^maxmind.json$']
- id: detect-secrets
args: ['--no-verify']
exclude_types: [json]
exclude: "README.md"
# Central hooks
- repo: https://github.com/phantomcyber/dev-cicd-tools
rev: feature/frictionless_connector_contributions # TODO: Update when time
hooks:
- id: build-docs
- id: copyright
- id: package-app-dependencies
- id: static-tests
1 change: 1 addition & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
# Contributing

For more information about contributing to Splunk SOAR Apps please take a look at our app [Contribution Guide](https://github.com/splunk-soar-connectors/.github/blob/main/.github/CONTRIBUTING.md)!
4 changes: 2 additions & 2 deletions LICENSE
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@
same "printed page" as the copyright notice for easier
identification within third-party archives.

Copyright (c) 2016-2024 Splunk Inc.
Copyright (c) 2016-2025 Splunk Inc.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
Expand All @@ -198,4 +198,4 @@
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
limitations under the License.
Loading
Loading