Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PAPP-34012 recognize msooxml files in all environments #20

Merged
merged 14 commits into from
Aug 12, 2024
Merged

PAPP-34012 recognize msooxml files in all environments #20

merged 14 commits into from
Aug 12, 2024

Conversation

ivellios
Copy link
Contributor

msooxml files should be recognized as such (not as zip) and handled properly in all environments (some OS don't support them properly in their magic library files definitions, so we patch them here)

  • removed dead code which was supposedly prepared to do the same
  • added msooxml magic definition file
  • checking against the file types using the added magic file
  • refactoring code to remove repeating parts

Closes PAPP-34012

Please check the type of change your PR introduces:

  • New App
  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Documentation
  • Other (please describe):

@jkamienski-splunk
PAPP-34012 msooxml files should be recognized as such (not as zip) an…
815a857 
…d handled properly in all environments (some OS don't support them properly in their magic library files definitions, so we patch them here)
@ivellios ivellios added the bug Something isn't working label May 23, 2024
jkamienski-splunk and others added 7 commits May 23, 2024 11:31
@ivellios ivellios marked this pull request as ready for review June 12, 2024 11:43
bb-splunk
bb-splunk requested changes Jul 10, 2024
View reviewed changes
@ivellios ivellios requested a review from bb-splunk July 11, 2024 07:20
@ivellios ivellios merged commit 796ef8d into next Aug 12, 2024
@ivellios ivellios deleted the jkamienski/PAPP-34012-handle_msooxml_files_being_recognized_as_zip_type branch August 12, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bb-splunk bb-splunk bb-splunk approved these changes

@mctonderski-splunk mctonderski-splunk mctonderski-splunk approved these changes

Assignees
No one assigned
Labels
bug Something isn't working splunk-supported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ivellios @bb-splunk @mctonderski-splunk @splunk-soar-connectors-bot @jkamienski-splunk