-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PAPP-34684] Splunk: Feature - Added 'splunk_job_timeout' parameter to asset config #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mposluszny-splunk
approved these changes
Sep 25, 2024
gbanas-splunk
approved these changes
Sep 25, 2024
bbielinski-splunk
added a commit
that referenced
this pull request
Sep 25, 2024
* [PAPP-34684] Splunk: Feature - Added 'splunk_job_timeout' parameter to asset config (#51) * Adding TODO * Bumping splunk-sdk to 2.0.1 * PAPP-34684: Added 'splunk_job_timeout' parameter to asset config. * Update README.md * PAPP-34684: Bumping pre-commit hooks and cleaning up wheels * PAPP-34684: Updated manual_readme_content.md * Update README.md * PAPP-34684: Removing unnecessary pass * Applying suggestion from review and linting * Updating pre-commit hooks --------- Co-authored-by: splunk-soar-connectors-admin <admin@splunksoar> * Release notes for version 2.17.0 --------- Co-authored-by: Bartosz Bieliński <[email protected]> Co-authored-by: splunk-soar-connectors-admin <admin@splunksoar> Co-authored-by: root <root@splunksoar>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please ensure your pull request (PR) adheres to the following guidelines:
Pull Request Checklist
Please check if your PR fulfills the following requirements:
<App Name>: <PR Type> - <PR Description>
next
branch of the forked repo. Create separate feature branch for raising the PR.Pull Request Type
Please check the type of change your PR introduces:
Security Considerations (REQUIRED)
please document them in the
manual_readme_content.md
.manual_readme_content.md
all methods (eg, OAuth) used to authenticatewith the service that the connector is integrating with.
manual_readme_content.md
.the Vault API.
nosemgrep
?If yes, please provide justification in an additional comment next to the ignored code.
Release Notes (REQUIRED)
Changelog:
What is the current behavior? (OPTIONAL)
The splunk connector doesn't track the amount of time it waits for the splunk job to finish so if job is stuck in "QUEUED" state (see related PAPP), the action will run indefinitely.
What is the new behavior? (OPTIONAL)
The splunk connector will track the amount of time it waits for the splunk job to finish and will time out this job if it exceeds set limit
Other information (OPTIONAL)
See screenshots
Pay close attention to (OPTIONAL)
n/a
Screenshots (if relevant)
New parameter "The duration in seconds to wait before a scheduled Splunk job times out" in asset settings:
Error message, when the job has timed out:

Thanks for contributing!