-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Splunk: Feature Add - Boolean to use event_id as SDI #54
Splunk: Feature Add - Boolean to use event_id as SDI #54
Conversation
Updated version, added contributer entry, added boolean config for event_id SDI
Added handling for using event_id as source data identifier when available if the asset boolean is checked
Added notes on new asset config value
Added change notes
Thank you for your submission! We have a total of 24 PRs open right now, and we are working hard on all of them! We will take a look as soon as we can. |
@zamastyle Static Tests results for commit 033459d - https://drive.google.com/file/d/1Ek9FOOA33gBaJAis5ahwJlt8NkVcjca2/view?usp=drivesdk |
@zamastyle Compile Tests results for commit 033459d - https://drive.google.com/file/d/12VsUN0y0up4ye0QJWlaXs_e2ZXqEtqzc/view?usp=drivesdk |
split comment line
@zamastyle Static Tests results for commit 616a055 - https://drive.google.com/file/d/1yb_bURwbpb9ltC1zEM8_ewJ4l9hdQ4qE/view?usp=drivesdk |
@zamastyle Compile Tests results for commit 616a055 - https://drive.google.com/file/d/1iYuSInyi7Qj8gHJoV80MWuHjJC4blXmW/view?usp=drivesdk |
Swapped single quotes for double quotes for ... reasons?
@zamastyle Static Tests results for commit bd93a01 - https://drive.google.com/file/d/10hTAuSfYx3Ixc8aV2ILxzzjKIKctKcbO/view?usp=drivesdk |
@zamastyle Compile Tests results for commit bd93a01 - https://drive.google.com/file/d/1Qet7bwMtG-xoDBeloyHnyRFtrh4_tZ_R/view?usp=drivesdk |
fixed param index int
@zamastyle Static Tests results for commit d87ab8e - https://drive.google.com/file/d/163gVJQfsRGmtnJpAuyxK2m44QLsBqlN8/view?usp=drivesdk |
@zamastyle Compile Tests results for commit d87ab8e - https://drive.google.com/file/d/1maIyBqmqQbWqoWCl4LqW_unxglvypBjU/view?usp=drivesdk |
@phantom-jacob Static Tests results for commit 789a29c - https://drive.google.com/file/d/16MOZ1GWxw__JhZqB_Rrf4B43WRioJ8NV/view?usp=drivesdk |
@phantom-jacob Static Tests results for commit faca1a4 - https://drive.google.com/file/d/19RNWfbTQscWAN097UuSgVqWAvglU1Pmq/view?usp=drivesdk |
3320f04
into
splunk-soar-connectors:next
@phantom-jacob Compile Tests results for commit faca1a4 - https://drive.google.com/file/d/1pMOP16eR4xLGP3RBjpjTKo_frpiujjoA/view?usp=drivesdk |
Please ensure your pull request (PR) adheres to the following guidelines:
Pull Request Checklist
Please check if your PR fulfills the following requirements:
<App Name>: <PR Type> - <PR Description>
next
branch of the forked repo. Create separate feature branch for raising the PR.Pull Request Type
Please check the type of change your PR introduces:
Security Considerations (REQUIRED)
please document them in the
manual_readme_content.md
.manual_readme_content.md
all methods (eg, OAuth) used to authenticatewith the service that the connector is integrating with.
manual_readme_content.md
.the Vault API.
nosemgrep
?If yes, please provide justification in an additional comment next to the ignored code.
Release Notes (REQUIRED)
Added 'use_event_id_sdi' parameter to asset config to allow updated event ingestion into the original container
What is the current behavior? (OPTIONAL)
The app currently uses a hash of the full event as the source data identifier which causes any updates to the event to be re-ingested as a wholly new container.
What is the new behavior? (OPTIONAL)
A boolean has been added to the asset config to allow using the event_id field value as the SDI. This changes the behavior to ingest any updated events as new artifacts under the original event container.
Other information (OPTIONAL)
Pay close attention to (OPTIONAL)
Screenshots (if relevant)
Thanks for contributing!