Merge pull request #6 from splunk/bug-pagination-issue

fix: fixed issue with Azure AD audit input creation
splunk · Jul 13, 2022 · 293e180 · 293e180
2 parents b4b28e0 + f3c3fb1
commit 293e180
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 7 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,4 +1,4 @@
-# Version 4.0.1
+# Version 4.0.2
 * Bug fix - Problem creating new AAD Audit Input - [Issue #3](https://github.com/splunk/splunk-add-on-microsoft-azure/issues/3)
 * Bug fix - Azure AD User and Group pagination issue
 

diff --git a/README.md b/README.md
@@ -12,7 +12,7 @@ This add-on is built with Splunk's [UCC Generator](https://github.com/splunk/add
 
 Example:
 
-    ucc-gen --ta-version=4.0.1
+    ucc-gen --ta-version=4.0.2
 
 The add-on will be built in an `output` directory in the root of the repository.
 

diff --git a/globalConfig.json b/globalConfig.json
@@ -2,7 +2,7 @@
     "meta": {
         "name": "TA-MS-AAD",
         "displayName": "Splunk Add-on for Microsoft Azure",
-        "version": "4.0.1",
+        "version": "4.0.2",
         "apiVersion": "3.0.0",
         "restRoot": "TA_MS_AAD",
         "schemaVersion": "0.0.3"
@@ -1028,14 +1028,15 @@
                     "entity": [
                         {
                             "type": "helpLink",
-                            "field": "AAD_sign_in_note",
+                            "field": "AAD_audit_note",
                             "label": "",
                             "help": "This input uses Microsoft Graph Azure AD activity reports and is subject to throttling limits. Refer to the documentation link above for more information.",
                             "tooltip": "Azure AD throttling guidance",
                             "options": {
                                 "text": "Azure AD throttling guidance",
                                 "link": "https://github.com/splunk/splunk-add-on-microsoft-azure/wiki/Configure-Azure-Active-Directory-inputs-for-the-Splunk-Add-on-for-Microsoft-Azure#throttling-guidance"
-                            }
+                            },
+                            "required": false
                         },
                         {
                             "field": "name",

diff --git a/package/app.manifest b/package/app.manifest
@@ -5,7 +5,7 @@
     "id": {
       "group": null,
       "name": "TA-MS-AAD",
-      "version": "4.0.1"
+      "version": "4.0.2"
     },
     "author": [
       {

diff --git a/package/bin/MS_AAD_audit.py b/package/bin/MS_AAD_audit.py
@@ -73,6 +73,10 @@ def get_scheme(self):
         scheme.add_argument(smi.Argument("name", title="Name",
                                          description="",
                                          required_on_create=True))
+        scheme.add_argument(smi.Argument("AAD_audit_note", title="",
+                                         description="Azure AD throttling guidance https://splunkbase.splunk.com/app/3757/#/details#throttling-guidance",
+                                         required_on_create=False,
+                                         required_on_edit=False))
         scheme.add_argument(smi.Argument("azure_app_account", title="Azure App Account",
                                          description="",
                                          required_on_create=True,

diff --git a/package/bin/MS_AAD_signins.py b/package/bin/MS_AAD_signins.py
@@ -73,7 +73,7 @@ def get_scheme(self):
         scheme.add_argument(smi.Argument("name", title="Name",
                                          description="",
                                          required_on_create=True))
-        scheme.add_argument(smi.Argument("AAD_sign_in_note", title=" Date",
+        scheme.add_argument(smi.Argument("AAD_sign_in_note", title="",
                                          description="Azure AD throttling guidance https://splunkbase.splunk.com/app/3757/#/details#throttling-guidance",
                                          required_on_create=False,
                                          required_on_edit=False))