Skip to content

Conversation

@rlieberman-splunk
Copy link
Collaborator

No description provided.

@vivekr-splunk vivekr-splunk self-requested a review November 10, 2025 18:13
@rlieberman-splunk rlieberman-splunk changed the base branch from develop to main November 21, 2025 15:29
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new GitHub Actions workflow for FOSSA open source scanning to enhance the repository's product security (prodsec) capabilities. The workflow integrates with Splunk's centralized OSS scanning infrastructure by calling a reusable workflow from the splunk/oss-scanning repository.

Key Changes:

  • Adds FOSSA OSS scanning workflow that runs on pull requests and pushes to main branch
  • Integrates with external reusable workflow from splunk/oss-scanning repository
  • Inherits secrets for authentication with FOSSA service

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 1 to 12
name: OSS Scan
on:
pull_request:
branches:
- main
push:
branches:
- main
jobs:
fossa-scan:
uses: splunk/oss-scanning/.github/workflows/oss-scan.yml@main
secrets: inherit
Copy link

Copilot AI Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow is missing a permissions declaration. All other workflows in this repository that call reusable workflows or perform security scanning explicitly define permissions (e.g., main.yml, scorecard.yml, codeql-analysis.yml).

Without explicit permissions, this workflow defaults to read-write for all scopes, which violates the principle of least privilege. Consider adding:

permissions: read-all

or more specific permissions if the FOSSA scan requires write access to certain scopes (check the splunk/oss-scanning documentation for requirements).

Copilot uses AI. Check for mistakes.
@coveralls
Copy link

coveralls commented Nov 21, 2025

Pull Request Test Coverage Report for Build 19578507505

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 36.822%

Totals Coverage Status
Change from base Build 19494067647: 0.0%
Covered Lines: 2336
Relevant Lines: 6344

💛 - Coveralls

@rlieberman-splunk rlieberman-splunk merged commit 08f2558 into main Nov 21, 2025
10 checks passed
@rlieberman-splunk rlieberman-splunk deleted the add_prodsec_workflow branch November 21, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants