Use dedicated macro for scala 3 enum type #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v0.8.x #983 +/- ##
=========================================
Coverage ? 95.18%
=========================================
Files ? 51
Lines ? 1827
Branches ? 153
=========================================
Hits ? 1739
Misses ? 88
Partials ? 0 ☔ View full report in Codecov by Sentry. |
RustedBones
force-pushed
the
scala3-enum-type
branch
from
7157399 to
8a84b29
Compare
RustedBones
commented
Jun 6, 2024
| @@ -49,7 +53,7 @@ trait EnumTypeDerivation { | |||
| val ns = sealedTrait.typeName.owner | |||
| val subs = sealedTrait.subtypes.map(_.typeclass) | |||
| val values = subs.flatMap(_.values).sorted.toList | |||
| val annotations = (sealedTrait.annotations ++ subs.flatMap(_.annotations)).toList | |||
There was a problem hiding this comment.
This is a bug to me. The base type should not get annotation from sub types.
There was a problem hiding this comment.
Clearly a desired behavior in the original commit but I am unsure why:
b5ac800#diff-a545d2c0ce087b812c645b66d7e3c15dde241f541434cb9bc0f6330d0570f281R34-R37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.