Skip to content

Commit

Permalink
fix: enable empty Or
Browse files Browse the repository at this point in the history
  • Loading branch information
kod-kristoff committed Feb 3, 2025
1 parent 3ba8bbd commit 3bbc6e5
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 6 deletions.
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[project]
name = "karp-api-client"
version = "0.1.0"
version = "0.1.1"
description = "Add your description here"
readme = "README.md"
authors = [
Expand Down
4 changes: 2 additions & 2 deletions src/karp_api_client/dsl/__init__.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
"""Karp query DSL."""

from .query import Equals, Query
from .query import Equals, Or, Query

__all__ = ["Equals", "Query"]
__all__ = ["Equals", "Or", "Query"]
4 changes: 2 additions & 2 deletions src/karp_api_client/dsl/query.py
Original file line number Diff line number Diff line change
Expand Up @@ -79,9 +79,9 @@ class Or(Query):

_param_defs: ClassVar[dict[str, dict[str, Union[str, bool]]]] = {"ors": {"type": "query", "multi": True}}

def __init__(self, first: Query, second: Query) -> None:
def __init__(self, *queries: Query) -> None:
"""Construct an Or query by combining two queries."""
super().__init__(ors=[first, second])
super().__init__(ors=list(queries))

def __or__(self, other: "Query") -> "Query":
"""Combine other query with or."""
Expand Down
8 changes: 7 additions & 1 deletion tests/test_dsl.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from karp_api_client.dsl import Equals
from karp_api_client.dsl import Equals, Or


def test_dsl(snapshot) -> None: # noqa: ANN001
Expand All @@ -7,3 +7,9 @@ def test_dsl(snapshot) -> None: # noqa: ANN001
actual = str(q)

assert actual == snapshot


def test_empty_or() -> None:
q = Or()

assert q.ors == []

0 comments on commit 3bbc6e5

Please sign in to comment.