-
Notifications
You must be signed in to change notification settings - Fork 203
Replace Bamboo SCDF samples build w/ GitHub actions #159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
...w-website/stream-developer-guides/streams/standalone-stream-sample/usage-cost-logger/pom.xml
Show resolved
Hide resolved
fbf1e48
to
4ce27cd
Compare
@@ -0,0 +1,76 @@ | |||
name: 'Build Sample App' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So... what are we doing for copyrights in our GH action files?
Versions for images could come from a pom file so that we don't need to modify workflows to change it. But that's minor thing and doesn't need to get done with this PR. I'd just merge this. Thx! |
Yep, the hardcoded aspect of the versions is toil to keep up-to-date. This is in parity w/ the old Bamboo plan and I plan on making this better in the scope of #156 (which I will follow on w/ shortly after this). |
Points of interest:
Possible improvements (TODO)
split the action.yml into 3 (build, publish, push)Resolves gh-155
cc: @dturanski @sobychacko