Skip to content

Replace Bamboo SCDF samples build w/ GitHub actions #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 21, 2022

Conversation

onobc
Copy link
Collaborator

@onobc onobc commented Jan 20, 2022

Points of interest:

  1. the push to Harbor registry will not work w/ public Github runners as we have to be on the VMware network
  2. the stream-standalone-sample have been modified to output the kafka and rabbit variants

Possible improvements (TODO)

  • remove version number from docker image inputs (will wait to do this in the clean-up of SCDF ticket where we bump version numbers)
  • split the action.yml into 3 (build, publish, push)

Resolves gh-155

cc: @dturanski @sobychacko

@onobc onobc requested a review from dturanski January 20, 2022 20:42
@onobc onobc force-pushed the gh-155-githubactions branch from fbf1e48 to 4ce27cd Compare January 21, 2022 02:28
@@ -0,0 +1,76 @@
name: 'Build Sample App'
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So... what are we doing for copyrights in our GH action files?

@jvalkeal
Copy link
Contributor

Versions for images could come from a pom file so that we don't need to modify workflows to change it. But that's minor thing and doesn't need to get done with this PR. I'd just merge this. Thx!

@onobc
Copy link
Collaborator Author

onobc commented Jan 21, 2022

Versions for images could come from a pom file so that we don't need to modify workflows to change it. But that's minor thing and doesn't need to get done with this PR. I'd just merge this. Thx!

Yep, the hardcoded aspect of the versions is toil to keep up-to-date. This is in parity w/ the old Bamboo plan and I plan on making this better in the scope of #156 (which I will follow on w/ shortly after this).

@onobc onobc merged commit ef1a52e into spring-cloud:main Jan 21, 2022
@onobc onobc deleted the gh-155-githubactions branch January 22, 2022 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate build from Bamboo to Github actions
4 participants