Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spring Cloud Data Flow fails to create composed tasks that contain $END #4387

Closed
cppwfs opened this issue Feb 11, 2021 · 1 comment · Fixed by #4392
Closed

Spring Cloud Data Flow fails to create composed tasks that contain $END #4387

cppwfs opened this issue Feb 11, 2021 · 1 comment · Fixed by #4392
Assignees
Labels
type/bug Is a bug report
Milestone

Comments

@cppwfs
Copy link
Contributor

cppwfs commented Feb 11, 2021

A composed task definition of timestamp '*'->t1: timestamp 'FOO'->$END does not pass dataflow validation because it says task:$END is not a valid application.
In the DefaultTaskService class where we saveStandardTaskDefinition (Line 110) for a composed task we need to gate it with a if statement like:

if(!composedTaskElementDefinition.getTaskName().contains("$END")) {
	saveStandardTaskDefinition(composedTaskElementDefinition);
}

This way $END is not treated like an app at task definition create time.

@cppwfs cppwfs added the type/bug Is a bug report label Feb 11, 2021
@cppwfs
Copy link
Contributor Author

cppwfs commented Feb 11, 2021

Refer to issue for additional detail: #4373

cppwfs added a commit to cppwfs/spring-cloud-dataflow that referenced this issue Feb 17, 2021
jvalkeal pushed a commit that referenced this issue Feb 22, 2021
- Updated to check task.name instead of task.taskName
- Updated to verify that taskNode.getName is not null before assessing if it contains $END
- resolves #4387
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Is a bug report
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants