Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

$END will not be validated as a app #4392

Merged
merged 2 commits into from
Feb 22, 2021
Merged

$END will not be validated as a app #4392

merged 2 commits into from
Feb 22, 2021

Conversation

cppwfs
Copy link
Contributor

@cppwfs cppwfs commented Feb 17, 2021

resolves #4387

@cppwfs cppwfs changed the title $END is now not validated as a app. $END is now will not be validated as a app Feb 17, 2021
@cppwfs cppwfs changed the title $END is now will not be validated as a app $END will not be validated as a app Feb 17, 2021
@jvalkeal
Copy link
Contributor

image
Would it be better to check if app name is $END instead of checking if task name ends with $END?

@cppwfs
Copy link
Contributor Author

cppwfs commented Feb 17, 2021

The name that is created for a composed task FOO is FOO-$END.

@jvalkeal
Copy link
Contributor

Ah yeah you're right about app name, but my point of using contains having it in label fails to create a second sub-task in t1: timestamp && t$END2: timestamp

@cppwfs
Updated to check task.name instead of task.taskName
2122c81 
Updated to verify that taskNode.getName is not null before assessing if it contains $END
@jvalkeal jvalkeal merged commit 16edca1 into spring-cloud:master Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jvalkeal jvalkeal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spring Cloud Data Flow fails to create composed tasks that contain $END
2 participants
@cppwfs @jvalkeal