Query param route predicate - extension of QueryRoutePredicateFactory

[polifr]

I tried to generalize the QueryRoutePredicateFactory so that it could use a bean of type Predicate instead of being limited to a regexp. Test classes are also implemented.

[spencergibb]

I'd prefer this in one class as having multiple query predicates is confusing.

[polifr]

@spencergibb you are suggesting to merge the two classes into one single predicate factory, that can manage both cases, right? I can do it, paying attention not to introduce regressions on the QueryRoutePredicateFactory.

[spencergibb]

@polifr yes, since this will only be available thru the java dsl, it should be ok. the regex can be retrofit to a Predicate.

[polifr]

@spencergibb I modified the QueryRoutePredicateFactory class to unify the regexp and predicate approach. Let me know if this is what you meant, so that I can proceed with adjustments on junit tests and cleaning of the previous proposal.

[spencergibb]

Yes, you can now remove QueryParamRoutePredicateFactory

[spencergibb]

Yes, you can now remove QueryParamRoutePredicateFactory

[polifr]

Ok, I removed the QueryParamRoutePredicateFactory and QueryParamRoutePredicateFactoryTests and extend the current QueryRoutePredicateFactoryTests to cover the new options. I also fixed the checkstyle errors that made the build fail.

[polifr]

Hi @spencergibb , is there something that stills blocks this pull request? I can't see any change request that has to be done.

[polifr]

There was a format error in the header of the test class, I fixed it.

[spencergibb]

@polifr can you add a commit signature for the DCO and then I will merge

[spencergibb]

Perfect, thanks