Skip to content

performance enhancement for request rate limiter lua script. #3693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

iis-MarkKuang
Copy link
Contributor

@iis-MarkKuang iis-MarkKuang commented Feb 11, 2025

Simplify request rate limiter lua script,
Regression tested with RedisRateLimiterLuaScriptTests.java.
Performance tested by stress testing on my own app, with lua script changes being the only variable.
For details please check issue #3681

@iis-MarkKuang iis-MarkKuang force-pushed the faster_rate_limiter_script branch from f01cddc to 6e0cd81 Compare February 12, 2025 01:26
@iis-MarkKuang iis-MarkKuang changed the title Simplify request rate limiter lua script. performance enhancement for request rate limiter lua script. Feb 13, 2025
@iis-MarkKuang
Copy link
Contributor Author

I see the build fails on a test case that is not relevant to the change, are there any actions required to push the PR forward?
Run URL: https://github.com/spring-cloud/spring-cloud-gateway/actions/runs/13276014053/job/38594233165?pr=3693
TC class:

@ryanjbaxter ryanjbaxter added this to the 4.3.0-M3 milestone Mar 13, 2025
@ryanjbaxter ryanjbaxter merged commit 50243c2 into spring-cloud:main Mar 13, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants