Update Config Watcher Configuration #1660
Conversation
Configure Renovate
| } | ||
|
|
||
| @AutoConfiguration | ||
| static class RefreshTriggerConfiguration { |
There was a problem hiding this comment.
not removed, but moved to a separate configuration class
| @Configuration | ||
| @Profile(KAFKA) | ||
| @Import({ ContextFunctionCatalogAutoConfiguration.class, RefreshTriggerConfiguration.class }) | ||
| static class BusKafkaConfiguration { |
There was a problem hiding this comment.
not removed, but moved to a separate auto-configuration class
| @Profile(AMQP) | ||
| @Import({ ContextFunctionCatalogAutoConfiguration.class, RabbitHealthContributorAutoConfiguration.class, | ||
| RefreshTriggerConfiguration.class }) | ||
| static class BusRabbitConfiguration { |
There was a problem hiding this comment.
not removed, but moved to a separate auto-configuration class
| @@ -46,13 +41,10 @@ | |||
| */ | |||
| @Configuration(proxyBeanMethods = false) | |||
| @EnableConfigurationProperties({ ConfigurationWatcherConfigurationProperties.class }) | |||
| @Import({ ConfigurationWatcherAutoConfiguration.RefreshTriggerConfiguration.class }) | |||
| @ConditionalOnCloudPlatform(CloudPlatform.KUBERNETES) | |||
| @Import({ RefreshTriggerConfiguration.class }) | |||
There was a problem hiding this comment.
two changes here :
@Importhas changed the class, since its not an inner class anymore- added
@ConditionalOnCloudPlatform(CloudPlatform.KUBERNETES)here, and for two other auto configuration for amqp and kafka
|
I want to extract some classes as individual auto configurations, because this will help me fix 1657. This PR does not do much, just extracts inner classes as separate auto-configuration ones @ryanjbaxter thank you for looking into it |
|
I guess I am confused on how these changes help fix the issue |
|
@wind57 see my comment above |
|
sorry, I missed that comment indeed. I had two ideas in my mind when creating this PR:
That is what I was leaning towards |
|
OK I am going to rename this issue since it is not actually directly addressing #1657. |
|
Perfect, thank you |
No description provided.