Fix UnrecognizedPropertyException in MCP WebFlux Transport #2484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor: Clean up McpWebFluxServerAutoConfiguration and add tests - Reorganize imports and improve code formatting for better readability. - Update `webFluxTransport` method to accept a custom `ObjectMapper`. - Introduce `McpWebFluxServerAutoConfigurationTests` to validate configuration and ensure proper handling of unknown JSON properties. Signed-off-by: Hari Ohm Prasath <[email protected]> Signed-off-by: Hari Ohm Prasth Rajagopal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix UnrecognizedPropertyException in MCP WebFlux Transport
Issue
When using the MCP server with WebFlux transport, the server fails with
UnrecognizedPropertyExceptionwhen receiving JSON payloads containing unknown fields. This occurs because the defaultObjectMapperconfiguration is too strict and fails on unknown properties.Fixes #2481
Changes
McpWebFluxServerAutoConfigurationto use Spring Boot's auto-configuredObjectMapperinstead of creating a new oneObjectMappercomes with Spring Boot's default settings, includingFAIL_ON_UNKNOWN_PROPERTIES=falseTesting
Added unit test that verifies:
ObjectMapperObjectMapperis configured to ignore unknown propertiesImpact
This change ensures that the MCP server can handle JSON payloads that may contain additional fields not defined in the model classes, which is particularly important for forward compatibility and client-server version mismatches.
Related PRs
N/A