Skip to content

S3 Vector Store implementation #4031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

MatejNedic
Copy link

@MatejNedic MatejNedic commented Aug 6, 2025

Before writing docs sadly there is no yet support for S3 Vector Store meaning I can do mock tests only. Is that fine or to skip mock tests completly?

#3834

@MatejNedic MatejNedic changed the title S3 Vecto Store implementation. S3 Vector Store implementation Aug 6, 2025
@MatejNedic
Copy link
Author

Hey @ilayaperumalg , before I polish everything fully and write docs. For S3VectorStore class there is no LocalStack implementation yet. Meaning I cannot write integration tests. I can write mock tests tho. So just asking how would Spring team like for me to proceed?

All of the code is done just making it more readable and fixing some imports here and there.

@MatejNedic MatejNedic force-pushed the #3834-introduce-vector-store-support branch from 11e1dbc to 4834be4 Compare August 7, 2025 07:44
@MatejNedic MatejNedic force-pushed the #3834-introduce-vector-store-support branch from 4834be4 to 5a1cf4a Compare August 7, 2025 07:58
@MatejNedic MatejNedic marked this pull request as ready for review August 9, 2025 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant