Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ExitStatus#isRunning for type-safety #4783

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Refactor ExitStatus#isRunning for type-safety #4783

wants to merge 7 commits into from

Conversation

sjiwon
Copy link

@sjiwon sjiwon commented Mar 15, 2025 •
edited
Loading

Overview

This PR improves the type-safety and readability of the ExitStatus#isRunning method in the Spring Batch core module.

Changes

  • Refactored the existing string-based comparisons in ExitStatus#isRunning by utilizing type-safe comparisons with predefined ExitStatus constants
  • Added unit tests covering the possible scenarios for the isRunning method, ensuring correct behavior for each relevant status:
    • return true: EXECUTING, UNKNOWN
    • return false: COMPLETED, FAILED, STOPPED, NOOP

@sjiwon sjiwon marked this pull request as draft March 15, 2025 07:41
@sjiwon sjiwon force-pushed the refactor/exit-status-type-safe-comparison branch from f023ff8 to 62f5c3a Compare March 15, 2025 07:58
@sjiwon sjiwon marked this pull request as ready for review March 15, 2025 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sjiwon