Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance of JdbcStepExecutionDao::getLastStepExecution #4798

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve performance of JdbcStepExecutionDao::getLastStepExecution #4798

wants to merge 1 commit into from

Conversation

quaff
Copy link
Contributor

@quaff quaff commented Mar 27, 2025

  1. Use SQL order by clause instead of Java Comparator
  2. Limit result set size to 1

@quaff
Improve performance of JdbcStepExecutionDao::getLastStepExecution
00b0126 
1. Use SQL order by clause instead of Java Comparator
2. Limit result set size to 1

Signed-off-by: Yanming Zhou <[email protected]>
@quaff
Copy link
Contributor Author

quaff commented Mar 27, 2025

Alternatively, we could use SE.STEP_EXECUTION_ID IN (SELECT MAX(STEP_EXECUTION_ID) FROM ...) to align with other queries, but there is a risk to break existing behavior since CREATE_TIME is not considered for comparing.

https://github.com/spring-projects/spring-batch/compare/main...quaff:spring-batch:patch-16?expand=1

@quaff quaff mentioned this pull request Mar 28, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@quaff