Default generic type arguments when resolving KType for Class. #3048
+56
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now fill up missing KTypeProjection arguments with star because the Kotlin Reflection.typeOf resolution fails if arguments are not provided.
mp911de
reviewed
Feb 21, 2024
|
|
||
| private static KTypeProjection[] stubKTypeProjections(KClass<?> kotlinClass) { | ||
|
|
||
| return IntStream.range(0, kotlinClass.getTypeParameters().size()).mapToObj(it -> KTypeProjection.star) |
There was a problem hiding this comment.
How about new KTypeProjection[kotlinClass.getTypeParameters().size()] and Arrays.fill(…) instead of using heavy-weight Stream API?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now fill up missing
KTypeProjectionarguments withstarbecause the KotlinReflection.typeOfresolution fails if arguments are not provided.Resolves: #3041