Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add native support for range field types by using a range object #1863

Merged
merged 2 commits into from
Jul 12, 2021

Conversation

xhaggi
Copy link
Contributor

@xhaggi xhaggi commented Jul 8, 2021

  • You have read the Spring Data contribution guidelines.
  • There is a ticket in the bug tracker for the project in our [issue tracker](https://github.
    com/spring-projects/spring-data-elasticsearch/issues)
    . Add the issue number to the Closes #issue-number line below
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

Closes #1862

@xhaggi xhaggi requested a review from sothawo July 8, 2021 13:04
@xhaggi xhaggi force-pushed the 1862-native-range-support branch from 24f8946 to baa0ea9 Compare July 8, 2021 13:06
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 8, 2021
@xhaggi xhaggi force-pushed the 1862-native-range-support branch 7 times, most recently from 7804d62 to d5ac215 Compare July 9, 2021 08:49
Copy link
Collaborator

@sothawo sothawo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work; i left a couple of comments.

What do you think about adding default range types like class IntegerRange extends Range<Integer>{}?

About the IPs - would be great to have that as well. I'll see if I find something useful

@xhaggi xhaggi force-pushed the 1862-native-range-support branch from d5ac215 to d1339d8 Compare July 12, 2021 09:36
@xhaggi xhaggi force-pushed the 1862-native-range-support branch from d1339d8 to 049d680 Compare July 12, 2021 10:12
Copy link
Contributor Author

@xhaggi xhaggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work; i left a couple of comments.

Thank you, I have addressed your comments.

What do you think about adding default range types like class IntegerRange extends Range{}?

I have no strong opinion on that. Writing Range or IntegerRange makes no difference to me.

About the IPs - would be great to have that as well.

Sure, but IMO we could add it later.

@xhaggi xhaggi requested a review from sothawo July 12, 2021 10:14
@xhaggi xhaggi force-pushed the 1862-native-range-support branch from 049d680 to 4294ace Compare July 12, 2021 14:05
@sothawo sothawo merged commit 271e1ee into spring-projects:main Jul 12, 2021
@xhaggi xhaggi deleted the 1862-native-range-support branch July 13, 2021 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add native support for range field types by using a range object
3 participants