-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add native support for range field types by using a range object #1863
Add native support for range field types by using a range object #1863
Conversation
24f8946
to
baa0ea9
Compare
7804d62
to
d5ac215
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work; i left a couple of comments.
What do you think about adding default range types like class IntegerRange extends Range<Integer>{}
?
About the IPs - would be great to have that as well. I'll see if I find something useful
src/main/java/org/springframework/data/elasticsearch/core/Range.java
Outdated
Show resolved
Hide resolved
src/main/java/org/springframework/data/elasticsearch/core/Range.java
Outdated
Show resolved
Hide resolved
...org/springframework/data/elasticsearch/core/convert/AbstractPersistentPropertyConverter.java
Outdated
Show resolved
Hide resolved
src/main/java/org/springframework/data/elasticsearch/core/Range.java
Outdated
Show resolved
Hide resolved
src/main/java/org/springframework/data/elasticsearch/core/Range.java
Outdated
Show resolved
Hide resolved
...pringframework/data/elasticsearch/core/convert/AbstractRangePersistentPropertyConverter.java
Show resolved
Hide resolved
...pringframework/data/elasticsearch/core/convert/AbstractRangePersistentPropertyConverter.java
Show resolved
Hide resolved
...pringframework/data/elasticsearch/core/convert/AbstractRangePersistentPropertyConverter.java
Outdated
Show resolved
Hide resolved
.../springframework/data/elasticsearch/core/convert/MappingElasticsearchConverterUnitTests.java
Show resolved
Hide resolved
.../springframework/data/elasticsearch/core/convert/MappingElasticsearchConverterUnitTests.java
Outdated
Show resolved
Hide resolved
d5ac215
to
d1339d8
Compare
d1339d8
to
049d680
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work; i left a couple of comments.
Thank you, I have addressed your comments.
What do you think about adding default range types like class IntegerRange extends Range{}?
I have no strong opinion on that. Writing Range or IntegerRange makes no difference to me.
About the IPs - would be great to have that as well.
Sure, but IMO we could add it later.
049d680
to
4294ace
Compare
com/spring-projects/spring-data-elasticsearch/issues). Add the issue number to the Closes #issue-number line below
Closes #1862