Remove unused QueryRendererBuilder locals in JPQL and HQL query renderers#4274
Open
jewoodev wants to merge 1 commit into
Open
Remove unused QueryRendererBuilder locals in JPQL and HQL query renderers#4274jewoodev wants to merge 1 commit into
jewoodev wants to merge 1 commit into
Conversation
…rers. JpqlQueryRenderer.visitString_expression declared a QueryRendererBuilder that is never used; the method returns either the subquery group or super.visitString_expression(ctx). HqlQueryRenderer.visitListaggFunction declared a `nested` builder that is never appended to, so the trailing appendInline(nested) is a no-op (appendInline returns early on an empty stream). Both are dead code with no effect on rendering. Signed-off-by: jewoodev <jewoos15@naver.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While following up on #4273, I found two leftover
QueryRendererBuilderlocals that are never used.This removes the unused builder in
JpqlQueryRenderer#visitString_expressionand the emptynestedbuilder plus no-opappendInline(nested)inHqlQueryRenderer#visitListaggFunction. Rendering behavior is unchanged.Verified with the JPQL/HQL/EQL renderer round-trip suites.