Translate transient WriteConflict to ConcurrencyFailureException#5195
Open
seonwooj0810 wants to merge 1 commit into
Open
Translate transient WriteConflict to ConcurrencyFailureException#5195seonwooj0810 wants to merge 1 commit into
seonwooj0810 wants to merge 1 commit into
Conversation
When a MongoException carries a TransientTransactionError label, return ConcurrencyFailureException (a TransientDataAccessException) instead of DataIntegrityViolationException so retry policies keyed on Spring's exception hierarchy can react accordingly. Applied in both the DATA_INTEGRITY_EXCEPTIONS branch and the isDataIntegrityViolationError fall-through branch. Closes spring-projects#5150 Signed-off-by: seonwooj0810 <seonwooj0810@gmail.com>
spring-projects-issues
added
the
status: waiting-for-triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WriteConflict (code 112) returned with a `TransientTransactionError` label is
a retryable concurrency failure, but `MongoExceptionTranslator` mapped it to
`DataIntegrityViolationException` — a `NonTransientDataAccessException` —
which silently breaks retry policies keyed on Spring's exception hierarchy.
This change checks `isTransientFailure(ex)` before falling through to
`DataIntegrityViolationException` and returns `ConcurrencyFailureException`
(a `TransientDataAccessException`) instead. The check is applied in both
the `DATA_INTEGRITY_EXCEPTIONS` branch (real `MongoWriteException`) and the
`isDataIntegrityViolationError` fall-through branch (plain `MongoException`
carrying a data-integrity error code).
Scope note: `MongoBulkWriteException` continues to return
`BulkOperationException` because bulk failures require per-write inspection
and were deemed out of scope for this fix.
Closes #5150