Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract creating of connection in ReactiveRedisTemplate into a separate method #2162

Closed
wants to merge 1 commit into from
Closed

Extract creating of connection in ReactiveRedisTemplate into a separate method #2162

wants to merge 1 commit into from

Conversation

petromir
Copy link
Contributor

@petromir petromir commented Sep 10, 2021 •
edited
Loading

A new method, called getConnection, is introduced in ReactiveRedisTemplate to allow overriding of connection creation.

Closes #2145

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).
  • You submit test cases (unit or integration tests) that back your changes.

@petromir
Extract creating of connection into a separate method
a8a2ef3 
A new method, called getConnection, is introduced to allow overriding of connection creation.

Closes #2145
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 10, 2021
@mp911de mp911de added this to the 2.5.5 (2021.0.5) milestone Sep 13, 2021
mp911de pushed a commit that referenced this pull request Sep 13, 2021
@petromir @mp911de
Extract connection creation into ReactiveRedisTemplate.getConnection(…
7781c8f 
…) method.

A new method, called getConnection, is introduced to allow overriding of connection creation.

Closes #2145
Original pull request: #2162.
mp911de added a commit that referenced this pull request Sep 13, 2021
@mp911de
Polishing.
d37341e 
Add author and since tags. Wrap connection allocation with fromSupplier(…). Move connection proxy decoration into doInConnection(…) as connection decoration isn't directly related to connection creation.

See #2145
Original pull request: #2162.
mp911de pushed a commit that referenced this pull request Sep 13, 2021
@petromir @mp911de
Extract connection creation into ReactiveRedisTemplate.getConnection(…
aaf7818 
…) method.

A new method, called getConnection, is introduced to allow overriding of connection creation.

Closes #2145
Original pull request: #2162.
mp911de added a commit that referenced this pull request Sep 13, 2021
@mp911de
Polishing.
7735a03 
Add author and since tags. Wrap connection allocation with fromSupplier(…). Move connection proxy decoration into doInConnection(…) as connection decoration isn't directly related to connection creation.

See #2145
Original pull request: #2162.
@mp911de
Copy link
Member

mp911de commented Sep 13, 2021

Thank you for your contribution. That's merged, polished, and backported now.

@mp911de mp911de closed this Sep 13, 2021
@mp911de mp911de added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 13, 2021
@petromir
Copy link
Contributor Author

You are welcome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
2.5.5 (2021.0.5)
Development

Successfully merging this pull request may close these issues.

Enable ReactiveRedisTemplate for multi-tenancy usage
3 participants
@petromir @mp911de @spring-projects-issues