breaking change for @Lock on String methods #2023
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mipo256 <[email protected]>
spring-projects-issues
added
the
status: waiting-for-triage
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
spring-data-jdbc/src/main/java/org/springframework/data/jdbc/repository/query/StringBasedJdbcQuery.java:149
- Replacing a warning with an exception for unsupported @lock usage is a breaking change. Ensure that clients invoking this API update to handle this exception and consider adding tests or documentation to clarify the new behavior.
throw new UnsupportedOperationException(LOCKING_IS_NOT_SUPPORTED + queryMethod);
|
Don't be scared, I requested out of interest a review from GitHub's copilot to see what happens. I never tried that so treat it as experiment. |
mp911de
force-pushed
the
main
branch
2 times, most recently
from
571fd96 to
1f2e694
Compare
|
Thanks. That's merged in 4.0.x |
schauder
added
type: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR completes the discussion here, but is a breaking change anyway, so I decided to clean up some APIs that were for removal anywhay.