Prevent cache pollution by storing only the factories #34732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update `SpringFactoriesLoader` so that the cache stores only the factories and not the complete loader. Prior to this commit, if a cache entry was added with the thread conect classloader, the loader instance would a added and the classloader stored. If the thread context classloader subsequently changes, and a call is made to `forDefaultResourceLocation` with `null` for the classloader, the cached entry would be used which contains the older classloader. Fixes spring-projectsgh-34732
philwebb
force-pushed
the
factories-loader-cache-pollution
branch
from
f7af69c to
6f59e55
Compare
spring-projects-issues
added
the
status: waiting-for-triage
philwebb
added a commit
to spring-projects/spring-boot
that referenced
this pull request
Apr 9, 2025
Update `SpringApplication` to work around `SpringFactoriesLoader` cache pollution by loading factories using a `null` class loader. See spring-projects/spring-framework#34732 for details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
SpringFactoriesLoaderso that the cache stores only the factories and not the complete loader.Prior to this commit, if a cache entry was added with the thread conect classloader, the loader instance would a added and the classloader stored. If the thread context classloader subsequently changes, and a call is made to
forDefaultResourceLocationwithnullfor the classloader, the cached entry would be used which contains the older classloader.