Skip to content

Commit

Permalink
Add pulsar-client-reactive-api to spring-pulsar-reactive (#614)
Browse files Browse the repository at this point in the history
The pulsar-client-reactive-api transitively includes the
pulsar-client-api. To insulate against different Pulsar client versions
in the Pulsar Reactive Client and Spring Pulsar we exclude this
transitive dependency and then include the version dictated by Spring
Pulsar. This is the same technique that is already done for the
pulsar-client-reactive-adapter.
  • Loading branch information
onobc authored Mar 15, 2024
1 parent 917ab52 commit fcf99aa
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
1 change: 1 addition & 0 deletions gradle/libs.versions.toml
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ micrometer-docs-gen = { module = "io.micrometer:micrometer-docs-generator", vers
micrometer-tracing-bom = { module = "io.micrometer:micrometer-tracing-bom", version.ref = "micrometer-tracing" }
protobuf-java = { module = "com.google.protobuf:protobuf-java", version.ref = "protobuf" }
pulsar-client-all = { module = "org.apache.pulsar:pulsar-client-all", version.ref = "pulsar" }
pulsar-client-reactive-api = { module = "org.apache.pulsar:pulsar-client-reactive-api", version.ref = "pulsar-reactive" }
pulsar-client-reactive-adapter = { module = "org.apache.pulsar:pulsar-client-reactive-adapter", version.ref = "pulsar-reactive" }
pulsar-client-reactive-producer-cache-caffeine-shaded = { module = "org.apache.pulsar:pulsar-client-reactive-producer-cache-caffeine-shaded", version.ref = "pulsar-reactive" }
pulsar-functions-api = { module = "org.apache.pulsar:pulsar-functions-api", version.ref = "pulsar" }
Expand Down
7 changes: 7 additions & 0 deletions spring-pulsar-reactive/spring-pulsar-reactive.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,16 @@ description = 'Spring Pulsar Reactive Support'

dependencies {
api project (':spring-pulsar')
api (libs.pulsar.client.reactive.api) {
// spring-pulsar includes a pulsar-client-api with its unwanted transitive deps excluded
exclude group: "org.apache.pulsar", module: "pulsar-client-api"
}
api (libs.pulsar.client.reactive.adapter) {
// spring-pulsar includes a pulsar-client with its unwanted transitive deps excluded
exclude group: "org.apache.pulsar", module: "pulsar-client"
// (above) we include a pulsar-client-reactive-api whose pulsar-client-api with
// unwanted transitive deps excluded
exclude group: "org.apache.pulsar", module: "pulsar-client-reactive-api"
}
api(libs.pulsar.client.reactive.producer.cache.caffeine.shaded) {
// (above) we include a pulsar-client-reactive-adapter whose pulsar-client with
Expand Down

0 comments on commit fcf99aa

Please sign in to comment.