Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update WebAuthn Test Objects Class Names #16604

Open
5 tasks
jzheaux opened this issue Feb 14, 2025 · 4 comments
Open
5 tasks

Update WebAuthn Test Objects Class Names #16604

jzheaux opened this issue Feb 14, 2025 · 4 comments
Assignees
@jzheaux @vasanth-79
Labels
in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement

Comments

@jzheaux
Copy link
Contributor

jzheaux commented Feb 14, 2025 •
edited
Loading

By convention, Spring Security test objects are named Test{Object}s, as in TestAuthentications or TestKeys.

It would be nice to rename the WebAuthn test objects like TestAuthenticatorAttestationResponse to TestAuthenticatorAttestationResponses.

As an exception, I think we should leave classes that are already pluralized as TestPublicKeyCredentialCreationOptions since TestPublicKeyCredentialCreationOptionses is a little tricky to say.

I believe the following is a comprehensive list of the classes to change:

  • TestAuthenticatorAttestationResponse
  • TestCredentialRecord
  • TestPublicKeyCredential
  • TestPublicKeyCredentialUserEntity
  • TestPublicKeyCredentialRpEntity
@jzheaux jzheaux added status: waiting-for-triage An issue we've not yet triaged type: enhancement A general enhancement status: first-timers-only An issue that can only be worked on by brand new contributors and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 14, 2025
@kiruthiga1793
Copy link

Hi @jzheaux , I'm interested. Can you please assign me?

@vasanth-79
Copy link

Hi @jzheaux
I'm interested. Could you please assign it to me?

@Chu3laMan Chu3laMan mentioned this issue Mar 1, 2025
Open
@mevilela
Copy link

Hello! @jzheaux.
I’m interested in contributing to this issue. Could you please assign me? :)

mevilela added a commit to mevilela/spring-security that referenced this issue Mar 24, 2025
@mevilela
Update WebAuthn Test Objects Class Names spring-projects#16604
592cfa2
@mevilela mevilela mentioned this issue Mar 24, 2025
Closed
@jzheaux jzheaux added in: web An issue in web modules (web, webmvc) and removed status: first-timers-only An issue that can only be worked on by brand new contributors labels Apr 1, 2025
@jzheaux jzheaux assigned vasanth-79 and unassigned mevilela Apr 1, 2025
jzheaux pushed a commit to Chu3laMan/spring-security that referenced this issue Apr 1, 2025
@Chu3laMan @jzheaux
Update WebAuthn Test Objects Class Names
f12ebdf 
Closes spring-projectsgh-16604
jzheaux added a commit to Chu3laMan/spring-security that referenced this issue Apr 1, 2025
@jzheaux
Rebase and Fix Formatting
33b62bd 
Issue spring-projectsgh-16604

Signed-off-by: Josh Cummings <[email protected]>
@jzheaux
Copy link
Contributor Author

jzheaux commented Apr 1, 2025

Sorry for a little bit of confusion here, @kiruthiga1793, @vasanth-79, and @mevilela and thank you all for your interest!

Since @vasanth-79 submitted a PR first, let's start there. @mevilela you are welcome to contribute to that PR from a review standpoint. Otherwise, I'll close your PR as a duplicate since it came after @vasanth-79's PR.

vasanth-79 added a commit to vasanth-79/update_webauthn_test_obj that referenced this issue Apr 2, 2025
@vasanth-79
Update WebAuthn Test Objects Class Names spring-projects#16604
2aaeca2 
Renamed the WebAuthn Test Object class names
vasanth-79 added a commit to vasanth-79/update_webauthn_test_obj that referenced this issue Apr 2, 2025
@vasanth-79
Update WebAuthn Test Objects Class Names spring-projects#16604
c1e4a86 
Renamed the WebAuthn Test Object class names

Signed-off-by: Vasanth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jzheaux jzheaux

@vasanth-79 vasanth-79

Labels
in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update WebAuthn Test Objects Class Names #16604 mevilela/spring-security
4 participants
@jzheaux @kiruthiga1793 @vasanth-79 @mevilela