Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test object factories to Test<Object>s naming convention #16686

Conversation

Chu3laMan
Copy link
Contributor

This PR addresses issue #16604 by renaming several WebAuthn test object classes to follow the established Spring Security convention of naming test objects as Test{Object}s (plural form).
Changes

Renamed TestAuthenticatorAttestationResponse → TestAuthenticatorAttestationResponses
Renamed TestCredentialRecord → TestCredentialRecords
Renamed TestPublicKeyCredential → TestPublicKeyCredentials
Renamed TestPublicKeyCredentialUserEntity → TestPublicKeyCredentialUserEntities
Renamed TestPublicKeyCredentialRpEntity → TestPublicKeyCredentialRpEntities

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 1, 2025
@jzheaux jzheaux force-pushed the Update-WebAuthn-Test-Objects-Class-Names branch from 9d97273 to 33b62bd Compare April 1, 2025 19:34
@jzheaux
Copy link
Contributor

jzheaux commented Apr 1, 2025

Thanks for the PR, @Chu3laMan! I addressed the formatting concerns in the PR in an additional commit. In order to merge, we'll need you to sign your commit and then update the PR accordingly. You should be able to do that as follows:

git rebase -i Update-WebAuthn-Test-Objects-Class-Names~2
// mark your commit as one to be edited
git commit -s --amend
git rebase --continue
git push origin +Update-WebAuthn-Test-Objects-Class-Names

@jzheaux jzheaux added in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 1, 2025
@Chu3laMan
Copy link
Contributor Author

Hi @jzheaux

It s done, thank you

@jzheaux jzheaux force-pushed the Update-WebAuthn-Test-Objects-Class-Names branch from 0c87671 to a96dcf5 Compare April 3, 2025 19:21
@jzheaux jzheaux self-assigned this Apr 3, 2025
@jzheaux jzheaux added this to the 6.5.0-RC1 milestone Apr 3, 2025
@jzheaux jzheaux merged commit 8cbe02e into spring-projects:main Apr 3, 2025
6 checks passed
@jzheaux
Copy link
Contributor

jzheaux commented Apr 3, 2025

@Chu3laMan, thanks for the PR. Note that I expanded the PR a bit so that now all classes follow the same convention.

@jzheaux jzheaux changed the title Update WebAuthn Test Objects Class Names Update test object factories to Test<Object>s naming convention Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants