Use determineTargetUrl() to retrieve redirect URL in SavedRequestAwareAuthenticationSuccessHandler
#16704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuezk
force-pushed
the
polish_SavedRequestAwareAuthenticationSuccessHandler
branch
from
aa86c76 to
3f10bbd
Compare
spring-projects-issues
added
the
status: waiting-for-triage
PR spring-projectsgh-16704 Signed-off-by: Kevin Yue <[email protected]>
yuezk
force-pushed
the
polish_SavedRequestAwareAuthenticationSuccessHandler
branch
from
3f10bbd to
070bb51
Compare
yuezk
changed the title
SavedRequestAwareAuthenticationSuccessHandler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
The
determineTargetUrl()in the subclass of theSavedRequestAwareAuthenticationSuccessHandlerno longer works because theSavedRequestAwareAuthenticationSuccessHandlerclass overrides theonAuthenticationSuccessmethod and no longer respects thedetermineTargetUrl()method.Use cases
We have a class that extends the
SavedRequestAwareAuthenticationSuccessHandlerbecause we want it to redirect to some specific URLs in some cases and use the saved request for others. Override thedetermineTargetUrl()could be an ideal solution, but theSavedRequestAwareAuthenticationSuccessHandlerbreaks it.