Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setCookieCustomizer should not reset withHttpOnlyFalse httpOnly setting #16822

Merged
merged 1 commit into from
Apr 1, 2025

Conversation

kse-music
Copy link
Contributor

Closes gh-16820

@jzheaux
Copy link
Contributor

jzheaux commented Mar 31, 2025

@kse-music, thanks for this PR. Since it also appears in 6.3.x, will you please rebase this to 6.3.x?

@jzheaux jzheaux added this to the 6.3.x milestone Mar 31, 2025
@jzheaux jzheaux self-assigned this Mar 31, 2025
@jzheaux jzheaux added in: web An issue in web modules (web, webmvc) type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 31, 2025
@kse-music kse-music changed the base branch from main to 6.3.x April 1, 2025 02:13
@kse-music
Copy link
Contributor Author

@jzheaux Rebase to 6.3.x has been completed.

@jzheaux jzheaux modified the milestones: 6.3.x, 6.3.9 Apr 1, 2025
@jzheaux jzheaux merged commit 857ef6f into spring-projects:6.3.x Apr 1, 2025
6 checks passed
@jzheaux jzheaux changed the title WithHttpOnlyCookie defaults to false setCookieCustomizer should not reset withHttpOnlyFalse httpOnly setting Apr 1, 2025
@jzheaux
Copy link
Contributor

jzheaux commented Apr 1, 2025

Thanks, @kse-music! This is now merged into 6.3.x, 6.4.x, and main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web An issue in web modules (web, webmvc) type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CookieServerCsrfTokenRepository.withHttpOnlyFalse() ineffective if setCookieCustomizer() is used
3 participants