Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Authentication#setAuthenticated #16838

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yybmion
Copy link

@yybmion yybmion commented Mar 28, 2025

This PR deprecates the Authentication#setAuthenticated method in favor of implementing isAuthenticated().

Changes

  • Add @Deprecated to Authentication#setAuthenticated
  • Update JavaDoc to explain the deprecation and recommended alternative
  • Add migration guidance in authentication.adoc

Closes gh-16668

This commit deprecates the Authentication#setAuthenticated method
in favor of implementing isAuthenticated().

Closes spring-projectsgh-16668

Signed-off-by: yybmion <[email protected]>
@yybmion
Copy link
Author

yybmion commented Apr 4, 2025

I'd like to provide an update on this PR. A specific commit (616b43f) has been merged into main, causing conflicts with my PR.
I want to confirm that documenting in the authentication.adoc file is the correct approach for addressing the requirement "Add to the migration doc instructions to stop using Authentication#setAuthenticated".
Once confirmed, I'll proceed with rebasing to resolve the conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate Authentication#setAuthenticated
2 participants