Warning when EnableTransactionManagement has lower precedence than EnableMethodSecurity #17665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ableMethodSecurity Warns when transaction management has same or lower precedence to prevent issues with @PostAuthorize rollback on methods with side effects. Fixes: spring-projects#17544 Signed-off-by: yybmion <[email protected]>
spring-projects-issues
added
the
status: waiting-for-triage
jzheaux
added
status: blocked
|
Thanks for this PR, @yybmion. I'm having some internal conversations with the Framework team about this, so I'd like to hold off on this warning for the moment. I'll post my findings here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds validation to ensure
@EnableTransactionManagementhas higher precedence than@EnableMethodSecurity, allowing proper transaction rollback when@PostAuthorizefails.Fixes #17544